feat(APP-4257): Update DataListItem to use div as a wrapper when non interactive - #501
Merged
Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
cgero-eth
reviewed
Jun 16, 2025
| }; | ||
|
|
||
| if (!isLinkElement) { | ||
| if (isLinkElement) { |
Contributor
There was a problem hiding this comment.
I believe we can remove the isSkeletonElement check above for applying the correct classes now, we introduced it to avoid displaying a pointer cursor for skeleton elements
Contributor
Author
There was a problem hiding this comment.
Yes, I double checked and I'm confident we can remove isSkeletonElement from dataListItem! I just updated default skeleton element with aria attributes as used in other "custom" skeletons.
Signed-off-by: Milos Dzepina <milos@aragon.org>
Co-authored-by: cgero.eth <ruggero.cino@gmail.com> Signed-off-by: Milos Dzepina <milos@aragon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
DataListItemto usedivas a wrapper when it's non interactive. Wrapper logic:hrefis set, wrap with linkonClickis set, wrap with buttondivTask: APP-4257
Type of change
Developer Checklist:
Review Checklist: